Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[extension/dbstorage] Flaky TestExtensionIntegrityWithPostgres #36212

Open
djaglowski opened this issue Nov 5, 2024 · 3 comments · May be fixed by #36267
Open

[extension/dbstorage] Flaky TestExtensionIntegrityWithPostgres #36212

djaglowski opened this issue Nov 5, 2024 · 3 comments · May be fixed by #36267
Labels
extension/storage/dbstorage flaky test a test is flaky needs triage New item requiring triage os:windows

Comments

@djaglowski
Copy link
Member

Component(s)

extension/storage/dbstorage

Describe the issue you're reporting

Observed on main here

=== FAIL: . TestExtensionIntegrityWithPostgres (15.07s)
    extension_test.go:148: 
        	Error Trace:	D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/extension/storage/dbstorage/extension_test.go:148
        	            				D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/extension/storage/dbstorage/extension_test.go:29
        	Error:      	Received unexpected error:
        	            	create container: Error response from daemon: could not find plugin bridge in v1 plugin registry: plugin not found
        	Test:       	TestExtensionIntegrityWithPostgres
@djaglowski djaglowski added the needs triage New item requiring triage label Nov 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@songy23 songy23 added flaky test a test is flaky os:windows labels Nov 5, 2024
@djaglowski
Copy link
Member Author

+1: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11725619291/job/32662397961?pr=36252#step:8:563

@pjanotti
Copy link
Contributor

pjanotti commented Nov 7, 2024

This is caused by the fact that on Windows GH runners Docker is set to run Windows containers, the test passes on Windows when running Docker is set to run Linux containers, but, notice that it consistently leaks a goroutine:

=== RUN   TestExtensionIntegrityWithPostgres
2024/11/07 12:01:04 (1) [] port not found
2024/11/07 12:01:05 (2) [] port not found
2024/11/07 12:01:05 (3) [] port not found
--- PASS: TestExtensionIntegrityWithPostgres (16.42s)
PASS
goleak: Errors on successful test run: found unexpected goroutines:
[Goroutine 20 in state syscall, locked to thread, with syscall.SyscallN on top of the stack:
syscall.SyscallN(0xc00010e298?, {0xc0002a1410?, 0x7ff7b9bdb0c0?, 0xc00010e240?})
        C:/Users/pjanotti/go/pkg/mod/golang.org/[email protected]/src/runtime/syscall_windows.go:544 +0x107
github.com/Microsoft/go-winio.getQueuedCompletionStatus(0x208, 0xc0000a1f8c?, 0xc0000a1f90?, 0xc0000a1f98?, 0xffffffff)
        C:/Users/pjanotti/go/pkg/mod/github.com/!microsoft/[email protected]/zsyscall_windows.go:327 +0xbb
github.com/Microsoft/go-winio.ioCompletionProcessor(0x208)
        C:/Users/pjanotti/go/pkg/mod/github.com/!microsoft/[email protected]/file.go:162 +0x85
created by github.com/Microsoft/go-winio.initIO in goroutine 19
        C:/Users/pjanotti/go/pkg/mod/github.com/!microsoft/[email protected]/file.go:58 +0x5d
]
FAIL    github.com/open-telemetry/opentelemetry-collector-contrib/extension/storage/dbstorage   17.344s

@pjanotti pjanotti linked a pull request Nov 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extension/storage/dbstorage flaky test a test is flaky needs triage New item requiring triage os:windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] Skip dbstorage extension tests on Windows GH runners pjanotti/opentelemetry-service-contrib
3 participants
@djaglowski @pjanotti @songy23