Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log and return nil if client not started #255

Open
jaronoff97 opened this issue Feb 27, 2024 · 0 comments
Open

Log and return nil if client not started #255

jaronoff97 opened this issue Feb 27, 2024 · 0 comments

Comments

@jaronoff97
Copy link
Contributor

Right now, opamp-go will return an error if you attempt to stop a client that hasn't been started. I would argue that should just be logged and an error shouldn't be returned. This comes in to conflict with the collector which expects shutting down a not-started component to return nil. ref: open-telemetry/opentelemetry-collector-contrib#31392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant