Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectionCount is incremented even no connection is created #21

Open
pistej opened this issue May 16, 2024 · 0 comments · May be fixed by #22
Open

connectionCount is incremented even no connection is created #21

pistej opened this issue May 16, 2024 · 0 comments · May be fixed by #22

Comments

@pistej
Copy link

pistej commented May 16, 2024

If some error/exceptions occurs in borrow() -> createConnection(), variable $connectionCount is incremented but no connection exist (can't be returned to pool), next borrow connection is trying to pop connection from channel but there is no connection ...

I would suggest same fix as in this forked lib, can create MR: eltaline@e5f8b2d

Q: Assume from code, there is no way init (or create connection) again when is closed ?!

@pistej pistej linked a pull request May 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant