Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: usernames should always remain in the same order to avoid unnecessary changes #209

Closed
nickytonline opened this issue Sep 29, 2024 · 4 comments
Labels
🐛 bug Something isn't working 👀 needs triage

Comments

@nickytonline
Copy link
Member

In #208, there are several changes where the order of the GitHub users changes and that's all.

CleanShot 2024-09-28 at 20 29 18

It would be nice to keep the order the same (alphabetical most likely) so that only actual owner changes are applied.

@nickytonline nickytonline added 🐛 bug Something isn't working 👀 needs triage labels Sep 29, 2024
@jpmcb
Copy link
Member

jpmcb commented Oct 2, 2024

The idea behind the original implementation is that the order matters: the people with the most changes show up first. This was more or less the easiest solution since we sort the contributors in each file based on their changes and then add the first 3 (where the first person has the most contributions).

@nickytonline
Copy link
Member Author

Cool cool. Thanks for the context @jpmcb!

@udaypatel1
Copy link
Contributor

@jpmcb – should this issue be closed or handled since it looks like it is resolved?

Just pointing it out to clean up Issues in the backlog.

@nickytonline
Copy link
Member Author

I'm going to go ahead and close this for now.

@nickytonline nickytonline closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 👀 needs triage
Projects
None yet
Development

No branches or pull requests

3 participants