feat: implement pizza offboard command
#207
Conversation
There was a problem hiding this comment.
This works, but it wasn't clear to me that I had to put a space between people or emails I wanted to offboard. I tried using a comma initially.
It'd also be nice to detect the .sauced.yaml like we do with generate.
A future feature could be loading a CSV of people to offboard, but now I'm scope creeping. 😅
| const offboardLongDesc string = `[WIP] Removes a user from the \".sauced.yaml\" config and \"CODEOWNERS\" files. | ||
| Requires the user's name OR email.` |
There was a problem hiding this comment.
Instead of [WIP], could be "Caution: Experimental command."
Could also include examples like we do elsewhere
| opts.ttyDisabled, _ = cmd.Flags().GetBool("tty-disable") | ||
| opts.configPath, _ = cmd.Flags().GetString("config") | ||
|
|
||
| opts.path, _ = cmd.Flags().GetString("path") |
There was a problem hiding this comment.
This flag likely needs to get marked as required. Otherwise, it attempts to use the default value:
❯ pizza offboard jpmcb
Error: error generating config file: error creating file: open : no such file or directory
|
|
||
| return nil | ||
| }, | ||
| RunE: func(cmd *cobra.Command, _ []string) error { |
There was a problem hiding this comment.
We should also initiate a Posthog client / runner for use with this command.
| err = generateConfigFile(opts.configPath, attributions) | ||
| if err != nil { | ||
| return fmt.Errorf("error generating config file: %v", err) | ||
| } |
There was a problem hiding this comment.
Something here seems to be broken since I get errors when it tries to re-generate the config if I don't provide a config:
pizza offboard jpmcb -p ./
I'd expect it'd look in the directory provided by -p to actually find a .sauced.yaml or fallback to the one in the user's home directory
Description
Implements a new
pizza offboardcommand that allows the user to offboard someone from the.sauced.yamlconfig andCODEOWNERSfiles by their attributed name or email.Related Tickets & Documents
Closes #117
Mobile & Desktop Screenshots/Recordings
Steps to QA
.sauced.yamlandCODEOWNERSfilespizza offboard <usernames/emails>with the user(s) you want to offboardpizza offboard zeudev [email protected]--path(-p) flag to specify what repository you are updating--config(-c) global flag to specify the configTier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?