Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: now the contributor insights new/edit page fits in smaller screens #3679

Merged

Conversation

nickytonline
Copy link
Member

@nickytonline nickytonline commented Jul 3, 2024

Description

The contributor insights edit page/new page is now responsive on smaller screens. Note that the add contributors modal is still not responsive. This will get addressed in a separate issue as this component is used elsewhere as well and needs to be responsive for all those use cases.

Related Tickets & Documents

Fixes #3668

Mobile & Desktop Screenshots/Recordings

Before

CleanShot 2024-07-03 at 13 05 49

After

CleanShot 2024-07-03 at 13 05 27

Note that when the grid is populated, it was always responsive.

CleanShot 2024-07-03 at 13 05 13

Steps to QA

  1. Open the deploy preview on your phone
  2. Create or edit a contributor insight in any workspace that you can edit.
  3. Notice the layout no longer bleeds out horizontally.

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit 215b2c7
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66858a9bb99ae100089ca0b2
😎 Deploy Preview https://deploy-preview-3679--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit 215b2c7
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66858a9b44996f0008fb1ff7
😎 Deploy Preview https://deploy-preview-3679--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nickytonline nickytonline requested review from isabensusan, BekahHW and a team July 3, 2024 17:12
@nickytonline nickytonline marked this pull request as draft July 3, 2024 17:21
@nickytonline nickytonline marked this pull request as ready for review July 3, 2024 17:29
@nickytonline nickytonline force-pushed the nickytonline/edit-contributor-insights-mobile-fixes branch from d18f935 to 215b2c7 Compare July 3, 2024 17:30
Copy link
Contributor

@zeucapua zeucapua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great on my phone!

@nickytonline nickytonline merged commit 256af40 into beta Jul 3, 2024
13 checks passed
@nickytonline nickytonline deleted the nickytonline/edit-contributor-insights-mobile-fixes branch July 3, 2024 19:43
open-sauced bot pushed a commit that referenced this pull request Jul 3, 2024
## [2.41.1-beta.2](v2.41.1-beta.1...v2.41.1-beta.2) (2024-07-03)

### 🐛 Bug Fixes

* now the contributor insights new/edit page fits in smaller screens ([#3679](#3679)) ([256af40](256af40))
open-sauced bot pushed a commit that referenced this pull request Jul 4, 2024
## [2.42.0](v2.41.0...v2.42.0) (2024-07-04)

### 🍕 Features

* add repo filtering to contributions tables on contributor profile ([#3580](#3580)) ([a2e49ef](a2e49ef))

### 🐛 Bug Fixes

* lottery factor copy ([#3682](#3682)) ([baac008](baac008))
* now OSCR column is hidden if feature flag is not enabled for OSCR ([#3676](#3676)) ([061c590](061c590))
* now the contributor insights new/edit page fits in smaller screens ([#3679](#3679)) ([256af40](256af40))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Contributor insight page and contributor repository new/edit pages spill out on mobile
3 participants