-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: now the contributor insights new/edit page fits in smaller screens #3679
Merged
nickytonline
merged 1 commit into
beta
from
nickytonline/edit-contributor-insights-mobile-fixes
Jul 3, 2024
Merged
fix: now the contributor insights new/edit page fits in smaller screens #3679
nickytonline
merged 1 commit into
beta
from
nickytonline/edit-contributor-insights-mobile-fixes
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
d18f935
to
215b2c7
Compare
zeucapua
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great on my phone!
brandonroberts
approved these changes
Jul 3, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
## [2.41.1-beta.2](v2.41.1-beta.1...v2.41.1-beta.2) (2024-07-03) ### 🐛 Bug Fixes * now the contributor insights new/edit page fits in smaller screens ([#3679](#3679)) ([256af40](256af40))
open-sauced bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
## [2.42.0](v2.41.0...v2.42.0) (2024-07-04) ### 🍕 Features * add repo filtering to contributions tables on contributor profile ([#3580](#3580)) ([a2e49ef](a2e49ef)) ### 🐛 Bug Fixes * lottery factor copy ([#3682](#3682)) ([baac008](baac008)) * now OSCR column is hidden if feature flag is not enabled for OSCR ([#3676](#3676)) ([061c590](061c590)) * now the contributor insights new/edit page fits in smaller screens ([#3679](#3679)) ([256af40](256af40))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The contributor insights edit page/new page is now responsive on smaller screens. Note that the add contributors modal is still not responsive. This will get addressed in a separate issue as this component is used elsewhere as well and needs to be responsive for all those use cases.
Related Tickets & Documents
Fixes #3668
Mobile & Desktop Screenshots/Recordings
Before
After
Note that when the grid is populated, it was always responsive.
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?