fix: now OSCR column is hidden if feature flag is not enabled for OSCR #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for design-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for oss-insights ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Can you confirm if you still see the table alignment issue? production beta update: I see it in your OP screenshot. I expect that it should be aligned. |
nickytonline
force-pushed
the
nickytonline/hide-oscr-colum
branch
from
3099c8c
to
5a62f31
Compare
bdougie
approved these changes
Jul 3, 2024
brandonroberts
approved these changes
Jul 3, 2024
open-sauced bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
## [2.41.1-beta.1](v2.41.0...v2.41.1-beta.1) (2024-07-03) ### 🐛 Bug Fixes * now OSCR column is hidden if feature flag is not enabled for OSCR ([#3676](#3676)) ([061c590](061c590))
open-sauced bot
pushed a commit
that referenced
this pull request
Jul 4, 2024
## [2.42.0](v2.41.0...v2.42.0) (2024-07-04) ### 🍕 Features * add repo filtering to contributions tables on contributor profile ([#3580](#3580)) ([a2e49ef](a2e49ef)) ### 🐛 Bug Fixes * lottery factor copy ([#3682](#3682)) ([baac008](baac008)) * now OSCR column is hidden if feature flag is not enabled for OSCR ([#3676](#3676)) ([061c590](061c590)) * now the contributor insights new/edit page fits in smaller screens ([#3679](#3679)) ([256af40](256af40))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OSCR data is hidden behind a feature flag, but the column wasn't. This PR removes the Rating column if the feature flag is not enabled.
Related Tickets & Documents
Fixes #3677
Mobile & Desktop Screenshots/Recordings
Before
Contributor Insight (Workspaces)
Explore page (contributors)
After
Contributor Insight (Workspaces)
Explore page (contributors)
Steps to QA
Tier (staff will fill in)
[optional] What gif best describes this PR or how it makes you feel?