Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: OSCR column visible in contributor list when feature flag is disabled #3677

Closed
nickytonline opened this issue Jul 3, 2024 · 3 comments · Fixed by #3676
Closed

Bug: OSCR column visible in contributor list when feature flag is disabled #3677

nickytonline opened this issue Jul 3, 2024 · 3 comments · Fixed by #3676
Assignees
@nickytonline
Labels
🐛 bug Something isn't working released on @beta released

Comments

@nickytonline
Copy link
Member

nickytonline commented Jul 3, 2024 •
edited
Loading

OSCR data is currently feature flagged and only appears if you have the oscr-rating feature flag enabled.

That works as expected, but @isabensusan noticed the column in the contributor list appears whether or not you have the feature flag enabled (just the column, not the data). It should be hidden if the feature flag is not enabled.
@nickytonline nickytonline added the 🐛 bug Something isn't working label Jul 3, 2024
@nickytonline nickytonline self-assigned this Jul 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Thanks for the issue, our team will look into it as soon as possible! If you would like to work on this issue, please wait for us to decide if it's ready. The issue will be ready to work on once we remove the "needs triage" label.

To claim an issue that does not have the "needs triage" label, please leave a comment that says ".take". If you have any questions, please comment on this issue.

For full info on how to contribute, please check out our contributors guide.

@nickytonline nickytonline mentioned this issue Jul 3, 2024
Merged
4 tasks
@open-sauced Open Sauced
Copy link
Contributor

open-sauced bot commented Jul 3, 2024

🎉 This issue has been resolved in version 2.41.1-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced Open Sauced
Copy link
Contributor

open-sauced bot commented Jul 4, 2024

🎉 This issue has been resolved in version 2.42.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@open-sauced open-sauced bot added the released label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickytonline nickytonline

Labels
🐛 bug Something isn't working released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: now OSCR column is hidden if feature flag is not enabled for OSCR open-sauced/app
1 participant
@nickytonline