Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add user avatar in header dropdown menu #3654

Closed
wants to merge 2 commits into from
Closed

fix: add user avatar in header dropdown menu #3654

wants to merge 2 commits into from

Conversation

ashudevcodes
Copy link

@ashudevcodes ashudevcodes commented Jun 28, 2024 •
edited
Loading

Description

fix user avatar in header dropdown menu

  • Replaced placeholder image with the logged-in user avatar

Related Tickets & Documents

Fixes #3646

Mobile & Desktop Screenshots/Recordings

image

Steps to QA

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

@netlify Netlify
Copy link

netlify bot commented Jun 28, 2024 •
edited
Loading

✅ Deploy Preview for oss-insights ready!

Name Link
🔨 Latest commit dda5c03
🔍 Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/66837f7c5083b800085f2a2b
😎 Deploy Preview https://deploy-preview-3654--oss-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed Jun 28, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@netlify Netlify
Copy link

netlify bot commented Jun 28, 2024 •
edited
Loading

✅ Deploy Preview for design-insights ready!

Name Link
🔨 Latest commit dda5c03
🔍 Latest deploy log https://app.netlify.com/sites/design-insights/deploys/66837f7cce697c000886eeff
😎 Deploy Preview https://deploy-preview-3654--design-insights.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot]
github-actions bot reviewed Jun 28, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord

@BekahHW
Copy link
Member

BekahHW commented Jul 1, 2024

Hey @ashudevcodes the compliance message (shown above) is specifically pointing to this part of the PR template: Can you add a key word (fixes, closes) before the issue number?
image

@ashudevcodes
Copy link
Author

Hey @ashudevcodes the compliance message (shown above) is specifically pointing to this part of the PR template: Can you add a key word (fixes, closes) before the issue number?

image

Ah! That's why got it, thanks! I'll add fixes before the issue number.

@nickytonline
Copy link
Member

Closing as per comment #3646 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Change the placeholder profile image in header dropdown with the user's image
3 participants
@ashudevcodes @BekahHW @nickytonline