Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useful skiboot artefacts are not copied to output directory #2415

Open
shenki opened this issue Oct 25, 2018 · 3 comments
Open

Useful skiboot artefacts are not copied to output directory #2415

shenki opened this issue Oct 25, 2018 · 3 comments

Comments

@shenki
Copy link
Member

shenki commented Oct 25, 2018

When building we end up with skiboot.lid and skiboot.lid.bin.

Ideally we would end up with skiboot.elf, and skiboot.lid.xz for p8, or skiboot.lid.xz.stb for p9.

@dcrowell77
Copy link
Contributor

I see skiboot.elf and skiboot.map included as part of output/images/host_fw_debug.tar.

@ghost
Copy link

ghost commented Dec 6, 2018

It gets weird here.

So, we assemble a skiboot.lid.xz as part of building skiboot - we build with xz -9 and CRC32. It turns out that update_images.pl in the pnor/ repo constructs its own compressed skiboot with the default xz compression level (6). So the skiboot build artifact is not being used.

Additionally, even though we produce the secure boot header with the imprint keys, the genPnorImages.pl script in the hostboot repository is what generates the secureboot header for the skiboot.lid that ends up in the PAYLOAD partition (via scripts in the pnor repo).

@ghost ghost self-assigned this Dec 6, 2018
@ghost
Copy link

ghost commented Dec 6, 2018

I'll assign this to myself as I'm reworking the trainwreck that is PNOR assembly currently and this issue should be resolved as a side-effect of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants