support fileDirname variable in roots configuration #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes LGTM, please update the commit to fix the DCO check https://github.com/open-policy-agent/vscode-opa/pull/31/checks?check_run_id=705346889 and add a node into the README to document that we support it (as-is we only mention the |
|
thanks @patrick-east . please see now |
tsandall
reviewed
May 27, 2020
patrick-east
approved these changes
May 29, 2020
|
@itaysk Go ahead and squash the changes when you have a chance |
Signed-off-by: Itay Shakury <[email protected]>
|
@patrick-east squashed |
|
is there a plan to cut a release sometime soon? the last release was a long time ago |
|
I can cut a release today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opa.rootsalready supports the conventional${workspaceFolder}built-in variable. This PR adds another conventional and useful variable:${fileDirname}which is resolved with the directory of the file opened in the active window. This was also mentioned in #27 where a user intuitively tried to use this but the extension didn't support it then.for reference: https://code.visualstudio.com/docs/editor/variables-reference