Sometimes notes are missing location even when enabled

[qcasey]

Location tracking on notes works about half the time on two of my devices, when it's missing there is a console error of:

Non-fatal location error Position acquisition timed out

Bumping the timeout to 6000 ms appears to fix this.

nomie6-oss/src/modules/locate/locate.ts

Line 34 in 12f22db

timeout: 3000,

Is anyone else experiencing this?

EDIT: Actually on my Android phone 6000 gets a fix ~80% of the time, 9000+ seems to work better from a cold start. I'll try pre-fetching location on initial load as well

[donalmacanri]

I hadn't noticed this issue before. Will try to reproduce ...

[donalmacanri]

I'm able to reproduce this now. The downside of increasing the timeout is that the note potentially waits that long before saving, which makes things feel quite laggy.

It would be nice to save the note immediately and save the location asynchronously, in the background, if necessary. However, I need to get more familiar with the storage implementations before attempting it.

[qcasey]

That is true, the many seconds of delay is annoying.

It would be nice to save the note immediately and save the location asynchronously, in the background, if necessary. However, I need to get more familiar with the storage implementations before attempting it.

This is the right way IMO. In the meantime I'm trying a fix where the location is fetched (and cached) on load. So far it's working OK.

[donalmacanri]

Nice, that should reduce the occurrence of the problem.

[donalmacanri]

@qcasey How has the fix been working out for you since - mind creating a PR?

[qcasey]

It's been working well for the most part. Sometimes (maybe 1 in 20) the location isn't fetched on load so I end up waiting the full 9 second timeout I configured like before. Still an improvement though.

The image I'm using is on ghcr.io/qcasey/nomie6-oss:fix-location-timeout-longer. I'll create a PR