Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing functions on windows #568

Closed
lplewa opened this issue Jun 26, 2024 · 7 comments
Closed

Implement missing functions on windows #568

lplewa opened this issue Jun 26, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@lplewa
Copy link
Contributor

lplewa commented Jun 26, 2024

Missing functions on windows should be implemented, and just return not supported return code.
Currently, we just do not export some linux only functions on windows.

@lplewa lplewa added the bug Something isn't working label Jun 26, 2024
@vinser52
Copy link
Contributor

Which API do you mean? Do we have a list?

@pbalcer
Copy link
Contributor

pbalcer commented Jun 26, 2024

I think we should only ifdef things that will never work on Windows or use nix-specific things (like file descriptors). Things that are currently unimplemented (but will be eventually) should just fail at runtime.

@lplewa
Copy link
Contributor Author

lplewa commented Jun 26, 2024

I think we should only ifdef things that will never work on Windows or use nix-specific things (like file descriptors). Things that are currently unimplemented (but will be eventually) should just fail at runtime.

This is also an option. ATM we just do not provide symbol which is just bad

@lplewa
Copy link
Contributor Author

lplewa commented Jun 26, 2024

Which API do you mean? Do we have a list?

$ diff <(grep -o '\bumf\w*' libumf.def.in | sort) <(grep -o '\bumf\w*' libumf.map | sort)

7a7
> umfLevelZeroMemoryProviderOps
29a30
> umfMemspaceCreateFromNumaArray
30a32,35
> umfMemspaceHighestBandwidthGet
> umfMemspaceHighestCapacityGet
> umfMemspaceHostAllGet
> umfMemspaceLowestLatencyGet

@lukaszstolarczuk
Copy link
Contributor

since this is about .def and .map files - isn't this related to/duplicate of #566 ?

@lplewa
Copy link
Contributor Author

lplewa commented Jun 26, 2024

since this is about .def and .map files - isn't this related to/duplicate of #566 ?

No - this is only similar issue:

  • those issue is about functions which was exported, but are not supposed to be exported. (internal function)
  • this issue is about functions which are supposed to be exported but there are not

@lplewa lplewa changed the title #ifdef API not avaiable on windows Implement missing functions on windows Jun 26, 2024
@vinser52
Copy link
Contributor

umfLevelZeroMemoryProviderOps

LevelZero provider should be supported on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants