Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua script location needs to be given correctly #226

Open
olliw42 opened this issue Nov 27, 2024 · 4 comments
Open

Lua script location needs to be given correctly #226

olliw42 opened this issue Nov 27, 2024 · 4 comments
Assignees

Comments

@olliw42
Copy link
Owner

olliw42 commented Nov 27, 2024

title says it

@jlpoltrack
Copy link
Collaborator

jlpoltrack commented Nov 28, 2024

This snippet from the Lua page looks okay to me - can you provide more specifics?

'The Lua script "mLRS.lua" or "mLRS-bw.lua" located in the "lua" folder of the mLRS github repository needs to be copied to the "SCRIPTS/TOOLS" folder of the radio's SD card. One can follow the common tutorials for how to do this.'

@olliw42
Copy link
Owner Author

olliw42 commented Nov 28, 2024

not really ok. The lua changes - not often but every once in a while - which can make it incompatible with previous versions. I.e., one cannot in general assume that the lua in main works with (all) previous firmware versions.
So it is with the lua in the main, it specifically asks for a minimum version of 1.3.03 - so will complain when used with e.g. v1.3.02. A user may however have difficulties to find currently the lua she/he should use ...

@jlpoltrack
Copy link
Collaborator

jlpoltrack commented Nov 28, 2024

Ok - so links for specific versions of the Lua and including the corresponding mLRS versions they support is what is wanted?

@jlpoltrack jlpoltrack self-assigned this Nov 28, 2024
@olliw42
Copy link
Owner Author

olliw42 commented Nov 28, 2024

I'm not totally sure how to handle that at this point in time.

so far we have proper tags only for stable versions, like 1.3.00. I want to change this to also have proper tags for the pre-release versions. So, v1.3.04 will be properly taged, so we can refer usesr to it. But we haven't done so far, so so far it's really ugly. I hope that we may not be that far from a v1.4.04, so maybe we leave it until when. The issue is just to note taht we need to give the users a better chance.

Maybe as quick fix we provide a link for v1.3.00 and v1.3.02. No idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants