Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing generic implementation or helper #10

Closed
bill-myers opened this issue Nov 17, 2023 · 2 comments
Closed

Missing generic implementation or helper #10

bill-myers opened this issue Nov 17, 2023 · 2 comments

Comments

@bill-myers
Copy link

bill-myers commented Nov 17, 2023

The crate seems to be missing a non-arch specific implementation, which forces anyone using gxhash to select another hash and use cfg directives to choose between them (obviously releasing non-specialized crates that only work on x86-64 and arm64 is not acceptable).

If the user selecting another hash is desired, then all GxHash types should take the other hash as a generic parameter, for user convenience.

@ogxd
Copy link
Owner

ogxd commented Nov 17, 2023

Yes you're right, it is important to provide a fallback. That's probably the 1st priority. Something can be done in the spirit of what is done for the crate ahash

@ogxd
Copy link
Owner

ogxd commented Dec 23, 2023

Closing as duplicate of #47

@ogxd ogxd closed this as completed Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants