Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The correct placement of the cycler closer -- Add 'note' in doumentation #403

Open
maltefritz opened this issue Mar 28, 2023 · 2 comments
Open

Comments

@maltefritz
Copy link
Collaborator

In a process with splitter and merge, I noticed that the location of the cycler closer is not trivial. The process works only if the component is placed in the part where the total mass flow is present.

So that others are not confronted with the same problem, I suggest to put the following note in dokumentation in 'tespy.components.basics.cycle_closer module':

If a cycle process is separated by a splitter or similar and reconnected by a merge or similar, this component has to be placed in the part of the prozess where the total mass flow is present.

If I find time, I will create a pull request to add this to the documentation.

Best regards

@fwitte
Copy link
Member

fwitte commented Mar 28, 2023

Hi @maltefritz,

thanks for reporting, do you have a minimal working example for that? I guess something like

a -> b
b -> c
b -> d
c -> cc (cycle closer)
cc -> e
d -> e
e -> a

does not work then, while placing the cycle closer between e and a or a and b would work?

@maltefritz
Copy link
Collaborator Author

Hi @fwitte,

your working example is right. The cycle closer only works between a and e or a and b. I think this component has to be placed in the part of the process where the total mass flow is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants