Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defect with framesets #98

Open
shawnmjones opened this issue Jul 10, 2018 · 0 comments
Open

Defect with framesets #98

shawnmjones opened this issue Jul 10, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@shawnmjones
Copy link
Member

URI-M: https://web.archive.org/web/19961221032254/http://www.geocities.com:80/BourbonStreet/1389/

It looks like there is a <frame> element without a src attribute and the code does not recover from that.

Applicable Application log entries:

[2018-07-10 10:15:38,793 -0600 ] - INFO - [ https://web.archive.org/web/19961221032254/http://www.geocities.com:80/BourbonStreet/1389/ ]: mementoembed - Starting oEmbed surrogate creation process
[2018-07-10 10:15:38,793 -0600 ] - DEBUG - [ https://web.archive.org/web/19961221032254/http://www.geocities.com:80/BourbonStreet/1389/ ]: mementoembed - output format will be: json
[2018-07-10 10:15:40,779 -0600 ] - DEBUG - [ https://web.archive.org/web/19961221032254/http://www.geocities.com:80/BourbonStreet/1389/ ]: mementoembed.mementoresource - URI-M https://web.archive.org/web/19961221032254/http://www.geocities.com:80/BourbonStreet/1389/ matches the wayback pattern
[2018-07-10 10:15:41,804 -0600 ] - INFO - [ https://web.archive.org/web/19961221032254/http://www.geocities.com:80/BourbonStreet/1389/ ]: mementoembed.mementoresource - memento is a Wayback memento
[2018-07-10 10:15:41,828 -0600 ] - DEBUG - [ https://web.archive.org/web/19961221032254/http://www.geocities.com:80/BourbonStreet/1389/ ]: mementoembed.mementoresource.MementoResource - title is Sax on the Web; Harri Rautiainen's Saxophone Page
[2018-07-10 10:15:41,831 -0600 ] - ERROR - [ https://web.archive.org/web/19961221032254/http://www.geocities.com:80/BourbonStreet/1389/ ]: mementoembed - An unforeseen error has occurred
Traceback (most recent call last):
  File "/Volumes/nerfherder External/Unsynced-Projects/MementoEmbed/mementoembed/__init__.py", line 363, in oembed_endpoint
    httpcache
  File "/Volumes/nerfherder External/Unsynced-Projects/MementoEmbed/mementoembed/mementosurrogate.py", line 28, in __init__
    self.originalresource = OriginalResource(self.memento, self.httpcache)
  File "/Volumes/nerfherder External/Unsynced-Projects/MementoEmbed/mementoembed/originalresource.py", line 20, in __init__
    self.content = self.memento.content
  File "/Volumes/nerfherder External/Unsynced-Projects/MementoEmbed/mementoembed/mementoresource.py", line 428, in content
    content = self.get_content_from_frames()
  File "/Volumes/nerfherder External/Unsynced-Projects/MementoEmbed/mementoembed/mementoresource.py", line 331, in get_content_from_frames
    frameuri = frame['src']
  File "/Users/smj/.virtualenvs/MementoEmbed/lib/python3.6/site-packages/bs4/element.py", line 1011, in __getitem__
    return self.attrs[key]
KeyError: 'src'
@shawnmjones shawnmjones added the bug Something isn't working label Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant