Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about match MVP #2266

Open
mrmerkone opened this issue Nov 1, 2020 · 4 comments
Open

Add information about match MVP #2266

mrmerkone opened this issue Nov 1, 2020 · 4 comments

Comments

@mrmerkone
Copy link

Is there any way to get information about MVP of the match?

@howardchung
Copy link
Member

Probably, since it can be looked up for old matches. It's probably in one of the GC responses somewhere

@mrmerkone
Copy link
Author

Any chance to get it in matches/<match_id> API soon or i can contribute it by myself?

Where should i look to add this info?

@howardchung
Copy link
Member

The protos in GameTracking-Dota2 might be a good place to start. You might need to NetHook the client to see what calls are being made, and it might need to be added to the node-dota2 repo. @Crazy-Duck might be able to offer some guidance

@Crazy-Duck
Copy link
Contributor

I haven't checked the protobufs in a while so don't know where the client is getting the MVP info. But I'd say NetHooking the client like Howard is suggesting is a good place to start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants