Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming pattern #42

Open
piotrbrzezina opened this issue Sep 9, 2019 · 2 comments
Open

Naming pattern #42

piotrbrzezina opened this issue Sep 9, 2019 · 2 comments

Comments

@piotrbrzezina
Copy link

piotrbrzezina commented Sep 9, 2019

Hi

On the beginning, I want to thanks for this great library.

I would like to know your opinion about what you think about adding to the configuration the possibility of creating name patterns for the queue dl and retry
curently thay are hardcoded to:

$retryQueueName = $name.'_retry_'.$retries[$i];
$this->createQueue($name.'_dl', array(
$this->createQueue($name.'_delay_'.$delay, array(

maybe we can create config value that can be overridden in a config file for this hardcoded string?
for example

parameters:
      dl_queue_patern: '%%queue_name%%_dl'
      retry_queue_patern: '%%queue_name%%_retry_%%retries%%'
      retry_queue_patern: '%%queue_name%%_delay_%%delay%%'

what do you think about that?

@odolbeau
Copy link
Owner

odolbeau commented Sep 9, 2019

Hi @piotrbrzezina & thanks for your issue.

That's the great idea, don't hesitate to create a PR to add this new feature! 👍

Just because I'm curious, can you describe your use case please? :)

@piotrbrzezina
Copy link
Author

piotrbrzezina commented Sep 9, 2019

Thanks for the quick reply

in our project, we have established a strategy for creating names for queues but this strategy is incompatible with the names that are used in this library. And we don't want to change our agreements because of the library :)

I will back to you with PR soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants