Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages according to the spec #3

Open
christopherL91 opened this issue Nov 20, 2016 · 1 comment
Open

Error messages according to the spec #3

christopherL91 opened this issue Nov 20, 2016 · 1 comment

Comments

@christopherL91
Copy link

Awesome lib! I'm really impressed on the quality of the lib. According to the spec there's a number of standardized error messages that are recommended to return if an error occurred, would this be something we could add to this lib?

Why is the soap module not included in the lib? Are there any particular reasons for not doing this?

@NormySan
Copy link
Contributor

Thanks!

The error messages is definitely something that could be added to the library, since the library throws it's own type of error this could probably be added to the error without much trouble.

As for having the soap library as a peer dependency, i thought that if someone uses the soap library for other things they can decide themselves what version of the library that they want as long as it's within the supported version-range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants