Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Expand Environments client for secrets and variables #2752

Closed
1 task done
timheuer opened this issue Jul 21, 2023 · 6 comments
Closed
1 task done

[FEAT]: Expand Environments client for secrets and variables #2752

timheuer opened this issue Jul 21, 2023 · 6 comments
Labels
Status: Stale Used by stalebot to clean house Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request

Comments

@timheuer
Copy link

Describe the need

On the Environments client it should expose the ability for retrieving the Secrets and Variables for each Environment

SDK Version

Octokit.net 7.0.1

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@timheuer timheuer added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Jul 21, 2023
@kfcampbell kfcampbell added Status: Up for grabs Issues that are ready to be worked on by anyone and removed Status: Triage This is being looked at and prioritized labels Jul 24, 2023
@nickfloyd nickfloyd added the hacktoberfest Issues for participation in Hacktoberfest label Sep 21, 2023
@drewid
Copy link

drewid commented Jan 9, 2024

Definitely have an interest in this, as the repository secrets just aren't granular enough. Plan on using those in conjunction with Azure Key Vault to have smooth GitHub to Azure deployment environment/branch/slot-related secrets.

@drewid
Copy link

drewid commented Jan 9, 2024

@timheuer @kfcampbell @nickfloyd - I looked at it and have done the core work on this along with tests. Have been able to sucessfully have get all, get specific, upsert, and delete environment secrets to all work.

My understanding per the guidelines is the method for contributing to the repository is to create a personal fork, then when work is finished create and push to a repo branch, and then create a pull request. I am not seeing the ability to create a branch - I assume my status need to be modified for contributing to the project? I also cannot assign myself the task so assume that is related.

@drewid
Copy link

drewid commented Jan 18, 2024

@timheuer @kfcampbell @nickfloyd checking back in on how you want me to proceed. Have implemented, tested and now have working live code changes done for both environment secrets and environment variables.

@nickfloyd nickfloyd removed the hacktoberfest Issues for participation in Hacktoberfest label Jan 18, 2024
@nickfloyd
Copy link
Contributor

@timheuer @kfcampbell @nickfloyd checking back in on how you want me to proceed. Have implemented, tested and now have working live code changes done for both environment secrets and environment variables.

Hey @timheuer Apologies for the delay on getting back to you and thanks for the follow up. Here are our contributing guidelines and some conventions that we use.

The basics are - create a fork, make your changes, write some tests, then create a PR. Because we serve more than 2000 external contributors across 75 different repos we have a process that we follow to help us prioritize things as well, have a look if you get the chance.

Most importantly, thank you for becoming part of the Octokit community! We cannot build the tools and help the millions of developers that we do without folks like you! So thank you ❤

Side note, I am going to review our contribution docs and see if I cannot simplify things there - please let me know if you have any feedback on those docs so that we can make them better for everyone!

@drewid
Copy link

drewid commented Jan 18, 2024

Thanks @nickfloyd. On the contribution docs, main thing is that it references creating a branch, which either is outdated or contributor needs specific access.

Per the conventions doc I will create a PR with the following for review:

feat: Adds Environment Secrets & Variables

Copy link

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

@github-actions github-actions bot added the Status: Stale Used by stalebot to clean house label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale Used by stalebot to clean house Status: Up for grabs Issues that are ready to be worked on by anyone Type: Feature New feature or request
Projects
Archived in project
Development

No branches or pull requests

4 participants