Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picture crop does not handle EXIF #9

Open
sagotch opened this issue Apr 12, 2016 · 2 comments
Open

Picture crop does not handle EXIF #9

sagotch opened this issue Apr 12, 2016 · 2 comments

Comments

@sagotch
Copy link
Contributor

sagotch commented Apr 12, 2016

Trying to upload a jpg with exif info may lead to wrong crop (e.g., the drawn orientation is not the real one). This is easy to see cropping a portrait picture taken from a smartphone.

I did not read the full spec of exif, but I started to try to reimplement exif parsing in https://github.com/exif-js/exif-js with js_of_ocaml for using a canvas and properly handling metadata, but this is not working yet.

(You can see it at https://github.com/sagotch/ocsigen-toolkit/tree/picture-uploader-fixing).

Note: even my ubuntu file browser does not handle exif when previewing images.
Note 2: http://www.daveperrett.com/articles/2012/07/28/exif-orientation-handling-is-a-ghetto/

@sagotch sagotch changed the title Picture crop does not handle EXIF (which means buggy cropping) Picture crop does not handle EXIF Apr 12, 2016
@dannywillems
Copy link
Member

@sagotch Is it fixed?

@sagotch
Copy link
Contributor Author

sagotch commented Dec 9, 2016

Nope...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants