-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use uucp caselesseq instead of structural equality and String.ascii_lowercase #2444
Labels
Comments
cuihtlauac
added
good first issue
Good for newcomers
beginner
can be done by an OCaml beginner
help wanted
labels
May 21, 2024
ran some grep to find the files where case-insensitive string comparision takes place:
|
looking into uucp functions to make those comparisions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
In the ocaml.org source code, strings are compared or searched, ignoring cases (i.e. in a case-insensitive manner). Most often, this is done using
String.lowercase_ascii
and either OCaml structural equality (=
) or standard library functions such asString.sub
orString.begins_with
.However, as @Octachron has noted, this is reckless. We'd better use robust, i18n-aware string functions from Uucp's library. Since this library is already part of what ocaml.org pulls, this does not create dependency considerations.
See: #2442
There are several tasks involved here:
The text was updated successfully, but these errors were encountered: