Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--ignore-promoted-rules has no effect on copy_files #10588

Open
eponier opened this issue May 27, 2024 · 1 comment
Open

--ignore-promoted-rules has no effect on copy_files #10588

eponier opened this issue May 27, 2024 · 1 comment
Labels

Comments

@eponier
Copy link
Contributor

eponier commented May 27, 2024

Actual Behavior

The documentation of copy_files refers to this page about modes specifying that --ignore-promoted-rules ignores rules with (mode promote), but this not true for copy_files.

Expected Behavior

I do not know if the proper fix is to change the code or change the documentation. In the first option, the code to change is here.

@emillon
Copy link
Collaborator

emillon commented May 27, 2024

Good catch. The tricky part in fixing that is determining if we need to version the fix or not.

@rgrinberg rgrinberg added the bug label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants