Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute @line is absent #3189

Open
volodya-lombrozo opened this issue May 17, 2024 · 3 comments
Open

Attribute @line is absent #3189

volodya-lombrozo opened this issue May 17, 2024 · 3 comments
Assignees
Labels

Comments

@volodya-lombrozo
Copy link
Member

I'm still trying to convert at least something from xmir to phi. At this time I faced with the problem related to line attribute in the xmir.

I have the following part in my xmir file:

 <o base="string" data="bytes" name="descriptor">4C 6F 72 67 2F 73 70 72 69 6E 67 66 72 61 6D 65 77 6F 72 6B 2F 62 6F 6F 74 2F 61 75 74 6F 63 6F 6E 66 69 67 75 72 65 2F 53 70 72 69 6E 67 42 6F 6F 74 41 70 70 6C 69 63 61 74 69 6F 6E 3B</o>

I run the xmir->phi transformation using the following configuration:

<plugin>
  <groupId>org.eolang</groupId>
  <artifactId>eo-maven-plugin</artifactId>
  <version>0.38.0</version>
  <executions>
    <execution>
      <id>convert-xmir-to-phi</id>
      <phase>generate-test-sources</phase>
      <goals>
        <goal>xmir-to-phi</goal>
      </goals>
      <configuration>
        <phiInputDir>${project.build.directory}/generated-sources/opeo-decompile-modified-xmir</phiInputDir>
        <phiOutputDir>${project.build.directory}/generated-sources/opeo-decompile-modified-phi</phiOutputDir>
      </configuration>
    </execution>
  </executions>
</plugin>

And get the following error:

[ERROR] net.sf.saxon.style.XSLMessage@17ce9dbf: Attribute @line is absent at "descriptor"
[ERROR] #fatalError(): Processing terminated by xsl:message at line 65 in add-refs.xsl; SystemID: file:///org/eolang/parser/add-refs.xsl; Line#: 65; Column#: 42

The entire file which I'm trying to convert:
FactorialApplication.xmir.txt

The entire log output I get:
build.log


I believe we have to remove this coupling with line numbers because we can generate xmir files not only from eo source code, so we just might not have lines.

@volodya-lombrozo
Copy link
Member Author

@yegor256 What do you think?

Copy link

@volodya-lombrozo thanks for the report, here is a feedback:

Problems

  • Clear title: Provide a more detailed title than "Attribute @line is absent" to enhance understanding of the problem.
  • Reproducibility steps: Include specific steps to reproduce the issue in the report.
  • Expected vs. Actual Result: The report should include a clear comparison between the expected outcome and the actual result.

I would recommend providing a clear comparison between the expected outcome and the actual result in the bug report.

Please fix the bug report in order it to get resolved faster.
Analyzed with gpt-4

@volodya-lombrozo volodya-lombrozo self-assigned this Jul 2, 2024
@volodya-lombrozo
Copy link
Member Author

I'll take this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant