Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP use is offered in offline mode #4

Open
swede89 opened this issue Sep 9, 2019 · 2 comments
Open

NTP use is offered in offline mode #4

swede89 opened this issue Sep 9, 2019 · 2 comments

Comments

@swede89
Copy link
Collaborator

swede89 commented Sep 9, 2019

The clock should only support non-ntp operation in AP mode

@swede89
Copy link
Collaborator Author

swede89 commented Sep 12, 2019

Steps to solve this issue:

  1. create additional settingsAP.html that excludes the option line „NTP usage (yes/no)“
  2. adapt the function void createCustomRoute(WebServer *server)
    • add parameter String file
    • replace "/settings.html" by parameter variable name file
  3. update function calls „createCustomRoute“ to run it for
    • API using parameter "/settings.html" and
    • AP using parameter "/settingsAP.html"
  4. update function void checkConfig(boolean init)
    • update line where ntpUse is retrieved to set boolean tempNtpUse ...
    • strcmp(config.ntpUse, "yes") == 0 and configManager.getMode() == 1
    • we might also consider checking the connected state WiFi.status() == WL_CONNECTED;
    • we might also consider combining this check with the checkWifi function to avoid repetition

@swede89
Copy link
Collaborator Author

swede89 commented Sep 12, 2019

1., 2. and 3. dont work.
4. is available in branch bugfixOfflineMode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant