Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: if external scored for SCORE then mac score for item should be i… #414

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

tikhanovichA
Copy link
Contributor

Increase MAX_SCORE if SCORE is external scored

Copy link

github-actions bot commented Oct 17, 2024

Coverage Report

Totals Coverage
Statements: 67.56% ( 9203 / 13622 )
Methods: 69.54% ( 1057 / 1520 )
Lines: 72.04% ( 5463 / 7583 )
Branches: 59.37% ( 2683 / 4519 )

StandWithUkraine

@tikhanovichA tikhanovichA requested review from a team, KirylHatalski, Karol-Stelmaczonek and viktar-dzmitryieu-tao and removed request for a team October 17, 2024 14:28
Copy link
Contributor

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master

Copy link

Version

Target Version 2.5.1
Last version 2.5.0

There are 0 BREAKING CHANGE, 0 feature, 6 fixes

@tikhanovichA tikhanovichA merged commit 8b18e32 into develop Nov 1, 2024
1 of 2 checks passed
@tikhanovichA tikhanovichA deleted the fix/MS-2872/set-external-for-score branch November 1, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants