Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: single order interaction #408

Merged
merged 4 commits into from
Jul 31, 2024

Conversation

viktar-dzmitryieu-tao
Copy link
Contributor

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao commented Jun 26, 2024

Ticket: https://oat-sa.atlassian.net/browse/AUT-3715

What's Changed

  • Added support of new options by order interaction (single and sort order)

How to test

  • Create an item containing order interactions with single and/or sort order options
  • Check different states, switching between views with different settings

PR in consumer: oat-sa/extension-tao-itemqti#2532

The changes are deployed to unit-06 construct

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao changed the base branch from master to develop June 26, 2024 13:02
Copy link

github-actions bot commented Jun 27, 2024

Coverage Report

Totals Coverage
Statements: 67.48% ( 9187 / 13614 )
Methods: 69.52% ( 1056 / 1519 )
Lines: 71.98% ( 5455 / 7579 )
Branches: 59.26% ( 2676 / 4516 )

StandWithUkraine

Copy link

github-actions bot commented Jul 8, 2024

Version

Target Version 2.4.0
Last version 2.3.3

There are 0 BREAKING CHANGE, 1 feature, 3 fixes

Copy link
Contributor

@Karol-Stelmaczonek Karol-Stelmaczonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

Copy link
Contributor

@jsconan jsconan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Checklist

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code respects code style rules
  • New code respects best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Pull request's target is not master
  • Commits are following conventional commits
  • Commits messages are meaningful
  • Commits are atomic

@viktar-dzmitryieu-tao viktar-dzmitryieu-tao merged commit efcebe4 into develop Jul 31, 2024
1 of 2 checks passed
@viktar-dzmitryieu-tao viktar-dzmitryieu-tao deleted the feat/AUT-3715/single-order-interaction branch July 31, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants