fix: rules for deleting SCORE and MAXSCORE outcomes #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
viktar-dzmitryieu-tao
requested review from
jsconan,
KirylHatalski and
Karol-Stelmaczonek
KirylHatalski
approved these changes
Jun 13, 2024
jsconan
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
It looks ok. Validated with unit tests.
Review Checklist
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code respects code style rules
- New code respects best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Pull request's target is not
master - Commits are following conventional commits
- Commits messages are meaningful
- Commits are atomic
Version
There are 0 BREAKING CHANGE, 0 feature, 3 fixes |
viktar-dzmitryieu-tao
deleted the
fix/AUT-3693/score-and-maxscore-variables-deleting
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://oat-sa.atlassian.net/browse/AUT-3693
What's Changed
SCOREandMAX_SCOREand applying DefaultSCOREValueSCOREandMAX_SCOREwill be deleted when response processing is none and all other outcomes marked withExternal scored=noneSCOREandMAX_SCOREwill NOT be deleted when response processing is none and at least one outcome marked withExternal scoredwithHumanorExternal machine0will be applied forSCOREoutcome for the case described just aboveHow to test
What's Changedsection.The changes applied in scope of oat-sa/extension-tao-itemqti#2524
Deployed to http://test-viktar.playground.kitchen.it.taocloud.org:41531/tao/Main/login