Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore manifest v3 with webext-redux v4 #2088

Open
buberdds opened this issue Nov 6, 2024 · 1 comment
Open

Explore manifest v3 with webext-redux v4 #2088

buberdds opened this issue Nov 6, 2024 · 1 comment
Assignees

Comments

@buberdds
Copy link
Contributor

buberdds commented Nov 6, 2024

No description provided.

@buberdds buberdds self-assigned this Nov 6, 2024
@buberdds
Copy link
Contributor Author

buberdds commented Nov 8, 2024

After quick prototyping https://github.com/oasisprotocol/wallet/compare/mz/manifest-v3?expand=1 this can "work". Tested with Ledger too.

Build problems

We can't use dynamic imports in service workers which affects dump validators fallback and dynamic webextension-polyfill imports, but these are easy fixes. The same problem occurs within our @oasisprotocol/ionic-ledger-hw-transport-bl package too. I did not look into details.

Runtime problems

Direct usage of window or document. In most cases this is related to localStorage usage. Maybe we could have utils to switch between chrome.storage and window.localStorage based on build type.

@tjanez tjanez changed the title Test manifest v3 with webext-redux v4 Explore manifest v3 with webext-redux v4 Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant