size is not the same as degree, but careless doc reader could make mistake

[bennetyee]

oasis-core/secret-sharing/src/poly/univariate.rs

Line 89 in 18da8bc

pub fn size(&self) -> usize {

because we don't trim high degree zeros, size does not return one more than the degree of the polynomial.

while this is not a bug, it feels like a potential foot gun for careless future users of this code.

[peternose]

size does not return one more than the degree of the polynomial.

True. Size returns the size of the underlying vector, which is the same as the number of (zero and non-zero) coefficients in the polynomial. Again avoiding degree to have constant time operations.

    /// Returns the number of coefficients in the polynomial.
    pub fn size(&self) -> usize {