Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when postUrl returns a rejected promise, pass the whole response back instead of just 'Server failure' #275

Open
susanm74 opened this issue Mar 3, 2023 · 3 comments
Assignees

Comments

@susanm74
Copy link
Contributor

susanm74 commented Mar 3, 2023

would make it easier for processing errors stored in the response.xyz (ex. response.body, response.json, response.json.error, response.json.file, etc) when it's desired to know more (or display more to the user) than just 'Server failure'

an idea that springs from issue 4347 / PR #276, but making a separate issue for this as the change itself and the testing burden would be nontrivial:

  • postJSON and postFormData both make a call to postUrl
  • postUrl is used directly by a few helpers and components:
    • contacts -> helpers -> closeTicket (although don't think this is actively used anywhere across TC, RP, FE repos)
    • Store
    • Modax
  • postJSON is used directly by:
    • 8 components
  • postFormData is used directly by:
    • 1 component
@susanm74
Copy link
Contributor Author

susanm74 commented Mar 3, 2023

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Without activity, this issue will be closed in 14 days.

@ericnewcomer
Copy link
Member

Assigning this just so it doesn't auto-close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants