Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contacts with ridiculous numeric values don't get indexed #31

Closed
nicpottier opened this issue Sep 1, 2020 · 3 comments
Closed

Contacts with ridiculous numeric values don't get indexed #31

nicpottier opened this issue Sep 1, 2020 · 3 comments

Comments

@nicpottier
Copy link
Collaborator

example:

"number": 700000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
@rowanseymour
Copy link
Member

Need to fix this goflow. In ES we're storing numbers as scaled_float which is a long scaled by 10000, so I think we have it that number parsing in the engine returns something in the range -922337203685477.5808 to 922337203685477.5807

@rowanseymour
Copy link
Member

Turns out people are using big numbers to model things like ID numbers so instead of trying to limit numbers to a range, for now we're using ignore_malformed to at least ensure that these documents are indexed tho without their big numbers.

@rowanseymour
Copy link
Member

Recently went and manually fixed all the places where strings that look like scientific notation numbers had been parsed as decimals so this shouldn't be a problem now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants