Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task to handle throttled expirations #364

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Add task to handle throttled expirations #364

merged 1 commit into from
Nov 20, 2024

Conversation

rowanseymour
Copy link
Member

Second half of #356

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 72.46377% with 19 lines in your changes missing coverage. Please review.

Project coverage is 62.23%. Comparing base (0eafabc) to head (ee6a392).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
core/tasks/expirations/cron.go 70.83% 10 Missing and 4 partials ⚠️
core/tasks/expirations/bulk_expire.go 83.33% 2 Missing and 1 partial ⚠️
core/tasks/timeouts/cron.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #364      +/-   ##
==========================================
+ Coverage   62.14%   62.23%   +0.08%     
==========================================
  Files         194      195       +1     
  Lines       13782    13806      +24     
==========================================
+ Hits         8565     8592      +27     
+ Misses       4306     4303       -3     
  Partials      911      911              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@rowanseymour rowanseymour merged commit fc22570 into main Nov 20, 2024
5 checks passed
@rowanseymour rowanseymour deleted the bulk_expire branch November 20, 2024 15:31
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants