Use compose component for Send Message action #1184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added validateCompose to flow action helpers - added getComposeStateToAction and getRecipientsStateToAction to flow action helpers - updated send msg and send broadcast stateToAction to use helper methods above - updated SendMsgForm and SendBroadcastForm initializeForm fn's to use helper methods above - updated SendMsgForm and SendBroadcastForm handleUpdate fn's to use validateCompose helper method - updated SendMsg main flow render to remove outer check for action.text and move to be an inner check for action.text - added ComposeElement to SendMsgForm - updated createSendMsgAction in assetCreators - added back attachments because MsgLocalizationForm still uses this todo - update unit tests
susanm74
changed the title
|
BEFORE |
|
AFTER |
|
note - this PR is on hold for now until it's confirmed how we'll handle migration/transference of the "conditional media url" functionality inclusive of the current attachment feature in the send message action attachments tab |
|
Without activity, this PR will be closed in 14 days. |
|
We agreed that the attachment code should work with old attachment formats as well. |
|
Without activity, this PR will be closed in 14 days. |
|
This PR was closed for inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1182
needs to be merged AFTER #1183 AND nyaruka/temba-components#315 are merged