Add send error for channel and contact pair limit hit that allow retr… #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
=======================================
Coverage 74.40% 74.41%
=======================================
Files 112 112
Lines 13493 13496 +3
=======================================
+ Hits 10040 10043 +3
Misses 2718 2718
Partials 735 735 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
norkans7
force-pushed
the
WAC-pair-limit-retry
branch
from
4ed6cd4
to
411c508
Compare
norkans7
commented
Nov 25, 2024
handlers/meta/handlers.go
Outdated
| @@ -1090,6 +1091,10 @@ func (h *handler) requestWAC(payload whatsapp.SendRequest, accessToken string, r | |||
| return courier.ErrResponseUnparseable | |||
| } | |||
|
|
|||
| if slices.Index([]int{4, 80007, 130429, 131048, 131056, 133016}, respPayload.Error.Code) > 0 { | |||
There was a problem hiding this comment.
Matching the error codes https://developers.facebook.com/docs/whatsapp/cloud-api/support/error-codes#throttling-errors to all be marked as throttle error and we retry up to 3 times
There was a problem hiding this comment.
this is odd way to check if x in y. Save the list of error codes as a global, then use slices.Contains
rowanseymour
requested changes
Nov 25, 2024
handlers/meta/handlers.go
Outdated
| @@ -1090,6 +1091,10 @@ func (h *handler) requestWAC(payload whatsapp.SendRequest, accessToken string, r | |||
| return courier.ErrResponseUnparseable | |||
| } | |||
|
|
|||
| if slices.Index([]int{4, 80007, 130429, 131048, 131056, 133016}, respPayload.Error.Code) > 0 { | |||
There was a problem hiding this comment.
this is odd way to check if x in y. Save the list of error codes as a global, then use slices.Contains
norkans7
force-pushed
the
WAC-pair-limit-retry
branch
from
0c0ed26
to
3693fe4
Compare
rowanseymour
approved these changes
Nov 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ying the message