Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for receiving MO JSON body #614

Closed
wants to merge 1 commit into from

Conversation

norkans7
Copy link
Contributor

@norkans7 norkans7 commented Aug 16, 2023

So far we support receiving Form and XML only

For aggregator that forward message as JSON body only we can support them with this PR changes

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #614 (0474a79) into main (adb84e4) will increase coverage by 0.33%.
Report is 3 commits behind head on main.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
+ Coverage   74.36%   74.70%   +0.33%     
==========================================
  Files          99       99              
  Lines       13347    13462     +115     
==========================================
+ Hits         9926    10057     +131     
+ Misses       2705     2685      -20     
- Partials      716      720       +4     
Files Changed Coverage Δ
handlers/external/external.go 89.35% <66.66%> (-1.40%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rowanseymour
Copy link
Member

If we don't need this now, I'm inclined to not make that channel type any more complicated

@rowanseymour rowanseymour deleted the MO-json-body-EX-channel branch August 24, 2023 14:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants