Fix retrieve media files for D3C #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkans7
commented
Aug 16, 2023
Comment on lines
+393
to
+400
| req, _ := http.NewRequest(http.MethodGet, mediaURL, nil) | ||
| req.Header.Set("User-Agent", utils.HTTPUserAgent) | ||
| req.Header.Set(d3AuthorizationKey, token) | ||
|
|
||
| resp, respBody, err := handlers.RequestHTTP(req, clog) | ||
| if err != nil || resp.StatusCode/100 != 2 { | ||
| return "", fmt.Errorf("failed to request media URL for D3C channel: %s", err) | ||
| } |
There was a problem hiding this comment.
Codecov Report
@@ Coverage Diff @@
## main #613 +/- ##
==========================================
- Coverage 74.36% 74.33% -0.04%
==========================================
Files 99 99
Lines 13347 13363 +16
==========================================
+ Hits 9926 9933 +7
- Misses 2705 2711 +6
- Partials 716 719 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rowanseymour
approved these changes
Aug 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the way to retrieve files from D3C which need an extra step to first retrieve the URL of the file and replacing the the Facebook URL to retrieve the actual file from D3C