Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont check for luarocks.nvim availabiity in checkhealth ? #1497

Open
2 tasks done
teto opened this issue Jul 1, 2024 · 0 comments
Open
2 tasks done

dont check for luarocks.nvim availabiity in checkhealth ? #1497

teto opened this issue Jul 1, 2024 · 0 comments
Labels
bug Issues related to bugs. Please attach a severity, a priority and category with this label.

Comments

@teto
Copy link

teto commented Jul 1, 2024

Prerequisites

  • I am using the latest stable release of Neovim
  • I am using the latest version of the plugin

Neovim Version

0.10++

Neorg setup

I dont think it's relevant but putting it out there

local M = {}

function M.setup_mappings()
vim.keymap.set('n', '<leader>wn', '<cmd>Neorg workspace notes<CR>', {silent = true}) -- just this block or blocks within heading section
vim.keymap.set('n', '<localleader>x', '<cmd>Neorg exec cursor<CR>', {silent = true}) -- just this block or blocks within heading section
vim.keymap.set('n', '<localleader>X', '<cmd>Neorg exec current-file<CR>', {silent = true}) -- whole file
end

function M.setup()
      require("neorg").setup {
        load = {
          ["core.defaults"] = {}, -- Loads default behaviour
          ["core.keybinds"] = {
            config = {
                default_keybinds = true,
            }
          },
          -- ["external.kanban"] = {},
          ["core.concealer"] = {}, -- Adds pretty icons to your documents
          ["core.ui.calendar"] = {},
          -- ['core.ui.calendar'] = {}, -- fails on stable nvim
          ["core.dirman"] = { -- Manages Neorg workspaces
            config = {
              workspaces = {
                notes =  "~/Nextcloud/local_notes",
                home = "~/Nextcloud/notes",
                work = "~/Nextcloud/nova/notes",
                ml = "~/Nextcloud/notes/ml",
                -- notes = "~/Nextcloud/Notes",
              },
              default_workspace = "notes"
            },
          },
          -- needs neorg-exec plugin
          -- ["external.exec"] = {},
        },
      }
end

M.setup()
M.setup_mappings()
vim.api.nvim_create_user_command('Notes', function()
	vim.cmd(":Neorg workspace notes")
	end, {
	desc = 'Opens my neorg notes.',
	})


return M

Actual behavior

I've installed neorg via rocks.nvim and I have vim.g.rocks_nvim set to

{                                                                                                                                                                                                                                                               
  luarocks_binary = "/nix/store/5j4av7r2aivkgcpqfr5z9zg1p45ga760-luarocks_bootstrap-3.11.0/bin/luarocks",                                                                                                                                                       
  luarocks_config = "/home/teto/.config/nvim/luarocks-config-generated.lua"                                                                                                                                                                                     
}       

because I want to handle luarocks installation via nix,

checkhealth shows an error:

neorg: require("neorg.health").check()

neorg ~
- Checking configuration...
- Checking `load` table...
- OK Module declaration `core.ui.calendar` is well-formed
- OK Module declaration `core.dirman` is well-formed
- OK Module declaration `core.defaults` is well-formed
- OK Module declaration `core.keybinds` is well-formed
- OK Module declaration `core.concealer` is well-formed
- OK Default configuration for logger provided, Neorg will not output debug info.
- Checking existence of dependencies...
- ERROR Required dependency `vhyrro/luarocks.nvim` not found! Neither `theHamsta/nvim_rocks` nor `camspiers/luarocks` are compatible. Check installation instructions in the README for how to fix the error.

neorg is working. I think neorg (and even rocks.nvim) should accept for the user to handle the luarocks installation ?

Expected behavior

No error in checkhealth

Steps to reproduce

Not sure how but I suspect using my own luarocks messed up something

{                                                                                                                                                                                                                                                               
  luarocks_binary = "/nix/store/5j4av7r2aivkgcpqfr5z9zg1p45ga760-luarocks_bootstrap-3.11.0/bin/luarocks",                                                                                                                                                       
  luarocks_config = "/home/teto/.config/nvim/luarocks-config-generated.lua"                                                                                                                                                                                     
}       

Potentially conflicting plugins

No response

Other information

No response

Help

None

Implementation help

Note that I've seen #1342 but this seemed to concern rocks.nvim as well.

@teto teto added the bug Issues related to bugs. Please attach a severity, a priority and category with this label. label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues related to bugs. Please attach a severity, a priority and category with this label.
Projects
None yet
Development

No branches or pull requests

1 participant