You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I didn't find the issue in existing issues or PRs.
How to reproduce the problem
Launching a terminal with term and thus starting vim.opt.shell will result in this filetype icon.
Expected behaviour
Launching a terminal with term pwsh will yield the expected result.
I don't quite get the difference other than that term pwsh will spawn 2 instances of pwsh as oppsed to term which will spawn just one instance of pwsh. In both cases filetype will be set to terminal by an autocommand. I tried several filetypes in the term session, but the icon didn't change. It also behaves the same for me no matter what shell you set. I even tried cmd.
Lines 35-37 would potentially recover the problem but don't get triggert as icon != null. Any particular reason why getting the icon like that instead of just using vim.bo.filetype in general? vim.bo.filetype would also kinda allow the users to make small modifications by changing a buffers file type, which might be a good thing?
Unfortunately some of my tests failed. One of the reason being that the filetype component test only simulates the buffer's filename and not the filetype (line 303 in component_spec.lua) . I will try to look further into it this weekend.
Self Checks
0a5a668
How to reproduce the problem
Launching a terminal with
![image](https://private-user-images.githubusercontent.com/42165023/337006855-9a9becfc-c098-49a1-ae4f-13e702c56fdc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1MzEyMjUsIm5iZiI6MTcyMDUzMDkyNSwicGF0aCI6Ii80MjE2NTAyMy8zMzcwMDY4NTUtOWE5YmVjZmMtYzA5OC00OWExLWFlNGYtMTNlNzAyYzU2ZmRjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA5VDEzMTUyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWEzMWY4ZGZmMTQxZDFiZmUxNmQzYTdjYzlhNGNlN2Q5YThkOGJjYTBiZTk5OGM2YmY4ZTQxZjMxNWE0NmU0MzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.bXDEBm6Ut0tE5tpGvGR0GSfeGgHUXd3YqsGTGJ_s8nU)
term
and thus startingvim.opt.shell
will result in this filetype icon.Expected behaviour
Launching a terminal with
![image](https://private-user-images.githubusercontent.com/42165023/337007240-38df24cd-8266-426f-9b04-7a6594581e1b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1MzEyMjUsIm5iZiI6MTcyMDUzMDkyNSwicGF0aCI6Ii80MjE2NTAyMy8zMzcwMDcyNDAtMzhkZjI0Y2QtODI2Ni00MjZmLTliMDQtN2E2NTk0NTgxZTFiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzA5VDEzMTUyNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMyYzg2NmZlMTQwNjU2OTYxNGY1ZGM5YzA0MjFjMGNlMGNjMTgyOTBjNGYzNWM4ZjZiM2Q0ZjI0MzQxOWRmMTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.y2Y_IccLClMDfXbxriKB0co7ORC7L4pMHXvCenNl6jw)
term pwsh
will yield the expected result.I don't quite get the difference other than that
term pwsh
will spawn 2 instances ofpwsh
as oppsed toterm
which will spawn just one instance ofpwsh
. In both casesfiletype
will be set toterminal
by an autocommand. I tried several filetypes in theterm
session, but the icon didn't change. It also behaves the same for me no matter what shell you set. I even triedcmd
.Minimal config to reproduce the issue
Additional information
OS: Windows 11 (10.0.22631)
Neovim: v0.10.0, Release, LuaJIT 2.1.1713484068
lualine:
0a5a668
Terminal: Windows Terminal v1.20.11381.0
The text was updated successfully, but these errors were encountered: