Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloudfront detection shouldn't rely on user-agent #141

Open
hecktarzuli opened this issue Apr 24, 2023 · 1 comment
Open

Cloudfront detection shouldn't rely on user-agent #141

hecktarzuli opened this issue Apr 24, 2023 · 1 comment
Labels
pending triage

Comments

@hecktarzuli
Copy link

It looks like the code only detects Cloudfront if the user-agent is Amazon Cloudfront. It should instead just detect the 2-3 device headers it uses and just use them if they exist.

We've been using Cloudfront device detection for a while, and our user-agents are whatever the user's browser is, not the value above. The change requested would accommodate a larger audience and configuration setups.
@hecktarzuli hecktarzuli changed the title Cloudflare detection shouldn't rely on user-agent Cloudfront detection shouldn't rely on user-agent Apr 24, 2023
@randompch
Copy link
Contributor

@hecktarzuli A PR regarding this issue would be greatly appreciated, don't hesitate to submit one 😊 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pending triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hecktarzuli @randompch @DamianGlowala