Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persian: Translation #49

Open
salitrov opened this issue Jan 29, 2024 · 21 comments
Open

Persian: Translation #49

salitrov opened this issue Jan 29, 2024 · 21 comments
Labels
translation submitted Translator submitted content for review & inclusion

Comments

@salitrov
Copy link

@marc-medley I didn't see an "issue" for a Persian translation and created one here. Hopefully that works. I'm attaching the translated .tsv files here, which began translation on November 3rd, so it may be based on an older .tsv template than the one currently available.

This particular language is also interested in using the Persian calendar as previously noted. Please let me know if there's anything else we can do. Thank you in advance for processing.

Persian_fa.app - Persian_fa.app.txt
Persian_fa.store - Persian_fa.store.txt

@marc-medley marc-medley added the translation submitted Translator submitted content for review & inclusion label Jan 30, 2024
@salitrov
Copy link
Author

Sorry—some additional translation changes have been made to these since yesterday. Unexpected. Reattaching here.

Persian_fa.app - Persian_fa.app.txt
Persian_fa.store - Persian_fa.store.txt

@marc-medley
Copy link
Member

marc-medley commented Jan 30, 2024

@salitrov The more recent files provided were normalized for review with the current releases. The resulting updated tsv spreadsheet files are listed below.

The normalized submission was reviewed and compared to the current releases. The following areas will need translation updates:

Line 6: "Serving Sizes (Suggested)"

The current releases have the addition of "(Suggested)" to "Servings Size".

// WAS
doze_detail_section_sizes	Serving Sizes

// NOW
doze_detail_section_sizes	Serving Sizes (Suggested)

Lines 11-14, 16-19: Beans (Legumes) Servings

// NOW (lines 11-14)
dozeBeans.Serving.imperial.1	½ cup cooked beans, split peas, or lentils
dozeBeans.Serving.imperial.2	½ cup tofu or tempeh
dozeBeans.Serving.imperial.3	1 cup fresh peas or snow peas
dozeBeans.Serving.imperial.4	1 cup fresh sprouted beans (lentils, mung beans)

// NOW (lines 16-19)
dozeBeans.Serving.metric.1	90 g cooked beans, split peas, or lentils
dozeBeans.Serving.metric.2	100 g tofu or tempeh
dozeBeans.Serving.metric.3	130 g fresh peas or snow peas
dozeBeans.Serving.metric.4	100 g fresh sprouted beans (lentils, mung beans)

Lines 198: Peanuts

Peanuts are now included.

dozeNuts.Variety.Text.7	Peanuts

Lines 248-249, 252-253: "Brussels sprouts", "Broccoli sprouts"

"Brussels or broccoli sprouts" are now separated into "Brussels sprouts" and "Broccoli sprouts".

// WAS
dozeVegetablesCruciferous.Serving.imperial.1	¼ cup Brussels or broccoli sprouts
dozeVegetablesCruciferous.Serving.metric.1	12 g Brussels or broccoli sprouts

// NOW
dozeVegetablesCruciferous.Serving.imperial.1	½ cup Brussels sprouts
dozeVegetablesCruciferous.Serving.imperial.2	¼ cup Broccoli sprouts
dozeVegetablesCruciferous.Serving.metric.1	80 g Brussels sprouts
dozeVegetablesCruciferous.Serving.metric.2	15 g Broccoli sprouts

@salitrov
Copy link
Author

Thank you, Marc. Attaching a revised version with those changes here. Please let me know if there's anything else we can do.

Persian_fa.app - Persian_fa.app.txt

@marc-medley
Copy link
Member

marc-medley commented Feb 2, 2024

@salitrov The 2024.01.31 Persian update processed OK. The next step of migrating the translations into the app source code discovered some addition sections that were completely missing from the outdated base-translation spreadsheet version. The Persian_fa.app.20240201.missing.tsv spreadsheet has the rows which also need to be added:

The missing sections:

  • FAQs
  • Export/Import history data
  • Analytics
  • "Special thanks to our volunteer translators"
    • A translator to decide whether or not their own name in included. Any names added are in language-code order. For Persian, the code is (fa).

It's ok to either add these rows to the main app translation spreadsheet; or, to translate and submit as a standalone spreadsheet.

@salitrov
Copy link
Author

salitrov commented Feb 5, 2024

Attaching those missing translations here. Please let me know if there's anything else we can do. Thank you.

Persian_fa.app.20240201.missing - Persian_fa.app.20240201.missing.txt

@marc-medley
Copy link
Member

The current processed versions of the Persian (fa) translations in TSV format are listed below:

The link for the Persian (fa) public beta TestFlight is https://testflight.apple.com/join/N0of1uH2. Anyone is welcome to test this version. Feedback can be provided directly through the TestFlight app.

As FYI, some test related details, specific to Daily Dozed iOS app, are being documented in the daily-dozen-ios repository Issue Ticket #78.

@salitrov
Copy link
Author

Hi Marc,

Thank you for your support. The translator, Saeed, has completed his initial review and changes were made to the original sheets he worked on. Additional revisions were made to them before the latest "current processed versions" you shared above and I hope it's not too much of a hassle to process updates with these older sheets. I have asked him to hold off on making any revisions in the meantime. He also shared some screenshots from his review that may require adjustments on your end. Please let me know if there's anything you'd like me to relay back to him. Thank you for considering.

Persian_fa.app - Persian_fa.app.txt
Persian_fa.app.20240201.missing - Persian_fa.app.20240201.missing.txt
Persian_fa.store - Persian_fa.store.txt

Screenshots.zip

@marc-medley
Copy link
Member

@salitrov The tsv versions provided are OK and the screenshots have useful detail. Thanks.

@salitrov
Copy link
Author

Hi Marc,

I'm attaching additional translation revisions from Saeed based on his reviews. Please let me know if there's anything else I can do. Thank you.
Persian_fa.app.v05 - Sheet1.txt
Persian_fa.store.v05 - Persian_fa.store.v05.txt

@salitrov
Copy link
Author

Please ignore the last comment. I was just told more revisions are coming.

@salitrov
Copy link
Author

This should be it. Thank you.

Persian_fa.app.v05 - Sheet1.txt
Persian_fa.store.v05 - Persian_fa.store.v05.txt

@marc-medley
Copy link
Member

@salitrov FYI, the March 28th Persian translation update in now available for iOS Daily Dozen in TestFlight beta version 3.5.1 (7). For Android Daily Dozen, the 20240328 Persian (fa) translation update #246 Pull Request has been submitted to be merged.

@salitrov
Copy link
Author

salitrov commented Apr 5, 2024

Thank you again, Marc. I have notified Saeed about this update.

@salitrov
Copy link
Author

Including more revisions here after the latest review. Thank you for processing.

Persian_fa.app.v05 - Sheet1.txt
Persian_fa.store.v05 - Persian_fa.store.v05.txt

@marc-medley
Copy link
Member

The current processed versions of the Persian (fa) translations in TSV format are listed below:

The 2024.04.26 translation update was released for public testing in version 3.5.1 (9) release on May 2nd.

The link for the Persian (fa) Test Group public beta TestFlight is https://testflight.apple.com/join/N0of1uH2. Anyone is welcome to test this version. Feedback can be provided directly through the TestFlight app.

@salitrov
Copy link
Author

Hello, a small translation update has been made (just to row 358 if that's easier to process). Thank you.
Persian_fa.app.v05 - Sheet1.txt

@marc-medley
Copy link
Member

marc-medley commented Jun 28, 2024

@salitrov The Persion localization spreadsheet has been updated and be found here:

… just to row 358 if that's easier to process

The intake processing utility AppLocalizer does an overall check for each submission.

In this case, the Android key numbering in lines 199 to 204 of the Persian_fa.app.v05 - Sheet1.txt file were also fixed. The image below shows the error which was found.

NutsNumbering

It would be good if the translator's copy was also updated to have this numbering fixed.

@salitrov
Copy link
Author

salitrov commented Jul 1, 2024

Thank you, Marc. Saeed made additional updates following this processing. I've attached the files here and corrected the numbering as noted.
Persian_fa.app.v05 - Sheet1.txt
Persian_fa.store.v05 - Persian_fa.store.v05.txt

@marc-medley
Copy link
Member

@salitrov @slavick

The 2024.07.01 Persian translation update has completed intake & normalization processing. This update has been pushed to the daily-dozen-localization in commit eb0d0bc

The processed and updated spreadsheets are here:

The next steps will to incorporate the translation update in the daily-dozen-android and daily-dozen-ios repositories for use with general releases.

@marc-medley
Copy link
Member

@salitrov Line 363 about_translators info_app_about_translators in Persian/tsv/v05/Persian_fa.app.v05.tsv needs to updated to include "Sabina Aliieva (uk)" for the Ukrainian translation.

@salitrov
Copy link
Author

Latest revision with that change. Thank you.
Persian_fa.app.v05 - Sheet1.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation submitted Translator submitted content for review & inclusion
Projects
None yet
Development

No branches or pull requests

2 participants