-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing factor in focusing factor & errors in analytic path length / travel time equations #648
Comments
I'm attaching a draft of the appendix of my thesis in which the focusing factor is derived. The above issues have been fixed in PR #649 |
As requested by @cg-laser , here are the checks on the impact of the new focusing factor (including the As expected, for the most part, this results in a slight decrease in the focusing factor (of up to 10%, though the 90th percentile is < 1 %). |
While writing this up for my thesis (draft attached), I found
Original:
Corrected:
These were checked against numerical integration:
check_new_analytic_traveltimes.pdf
check_new_analytic_pathlength.pdf
and observed to agree within the 1e-4 numerical integration precision. Note that the previous formulas
I see no reason why any issues should have arisen in these (clearly) finite integrals in the first place, but someone else can plug the equations into WolframAlpha again if they fancy.
The text was updated successfully, but these errors were encountered: