Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add emtpy feed #394

Open
sukiletxe opened this issue Feb 8, 2022 · 3 comments
Open

Cannot add emtpy feed #394

sukiletxe opened this issue Feb 8, 2022 · 3 comments
Labels
bug 🐞🐛🐜 Something isn't working

Comments

@sukiletxe
Copy link

Add-on version
Add-on version: 3.4

Describe the bug
Currently I can't add empty feeds (use case: comment feeds where: there are no comments; I've commented; but the comment is pending moderation (so the feed is still empty).

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://ctrl.blog and look for posts with no comments (there should be plenty)
  2. Click on post comment.
  3. Click on feed, then try subscribing.
  4. Nothing happens.

Expected behavior
The add-on should have added the empty feed to the livemarks.

@evilpie
Copy link
Collaborator

evilpie commented May 28, 2022

We usually consider empty feeds to be some kind of parsing problem and thus don't allow adding them.

@sukiletxe
Copy link
Author

Woops, forgot to reply to this. If I understand the RSS and ATOM specs correctly, it seems that RSS requires only title, link and description, and ATOM only id, title and updated. Granted, I don't know how valid feeds are in the web, but feeds without items are technically allowed.

@nt1m
Copy link
Owner

nt1m commented Nov 3, 2023

We should probably allow subscribing to empty feeds.

@nt1m nt1m added the bug 🐞🐛🐜 Something isn't working label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞🐛🐜 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants