Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes unknown enum values are lost #606

Open
cthulhu-rider opened this issue Jul 22, 2024 · 1 comment
Open

Sometimes unknown enum values are lost #606

cthulhu-rider opened this issue Jul 22, 2024 · 1 comment
Labels
bug Something isn't working I4 No visible changes S4 Routine U3 Regular

Comments

@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Jul 22, 2024 •
edited
Loading

currently, Unmarshal / UnmarshalJSON of eACL and constituent types loses unknown enum value and shrinks them to 0. This should not be done: callers shouls be able to access real value and decide what to do on their own
@cthulhu-rider cthulhu-rider added the bug Something isn't working label Jul 22, 2024
@roman-khimov roman-khimov added U3 Regular S4 Routine I4 No visible changes labels Jul 22, 2024
cthulhu-rider added a commit that referenced this issue Jul 23, 2024
@cthulhu-rider
eacl: Skip currently failing unit tests
0a9012f 
Caused by #606 which should make them PASS.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit that referenced this issue Jul 23, 2024
@cthulhu-rider
eacl: Skip currently failing unit tests
6b49434 
Caused by #606 which should make them PASS.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit that referenced this issue Jul 24, 2024
@cthulhu-rider
eacl: Skip currently failing unit tests
6f2b7e9 
Caused by #606 which should make them PASS.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit that referenced this issue Jul 25, 2024
@cthulhu-rider
eacl: Skip currently failing unit tests
f116319 
Caused by #606 which should make them PASS.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit that referenced this issue Jul 30, 2024
@cthulhu-rider
eacl: Skip currently failing unit tests
f2746cb 
Caused by #606 which should make them PASS.

Signed-off-by: Leonard Lyubich <[email protected]>
@cthulhu-rider cthulhu-rider changed the title eacl: Unknown enum values are lost Sometimes unknown enum values are lost Aug 2, 2024
@cthulhu-rider
Copy link
Contributor Author

plus session verbs

cthulhu-rider added a commit that referenced this issue Aug 7, 2024
@cthulhu-rider
eacl: Skip currently failing unit tests
68f39d8 
Caused by #606 which should make them PASS.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit that referenced this issue Aug 9, 2024
@cthulhu-rider
eacl: Skip currently failing unit tests
7f9e1cd 
Caused by #606 which should make them PASS.

Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider added a commit that referenced this issue Aug 9, 2024
@cthulhu-rider
eacl: Skip currently failing unit tests
402b83c 
Caused by #606 which should make them PASS.

Signed-off-by: Leonard Lyubich <[email protected]>
@cthulhu-rider cthulhu-rider mentioned this issue Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working I4 No visible changes S4 Routine U3 Regular
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roman-khimov @cthulhu-rider