Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop breaking database compatibility! #3183

Closed
532910 opened this issue Nov 1, 2023 · 4 comments
Closed

Stop breaking database compatibility! #3183

532910 opened this issue Nov 1, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@532910
Copy link

532910 commented Nov 1, 2023

Why the hell does this happens almost on every release? The only possible place for such things is major releases, like for APIs, protocols, etc.

@532910 532910 added the bug Something isn't working label Nov 1, 2023
@AnnaShaleva
Copy link
Member

We don’t have major releases now, thus, every time the DB format is being changed we update the minor version. This scheme won’t be changed until we have major version.

Why the hell does this happens almost on every release?

We do change the DB format only in emergency cases or for incompatible features.

@AnnaShaleva AnnaShaleva closed this as not planned Won't fix, can't repro, duplicate, stale Nov 1, 2023
@532910
Copy link
Author

532910 commented Nov 9, 2023

0.103.1 is not even a minor version, it's a PATCH!

@532910 532910 reopened this Nov 9, 2023
@roman-khimov
Copy link
Member

And it's state-compatible with 0.103.0. 100%. It's just that some (and frankly, maybe just a single one on a single network, #3190) application logs can be bad.

@roman-khimov
Copy link
Member

We will do resynchronizations until we have state roots in the header, see neo-project/neo#1526, that's just inevitable. And to be fair, it's not that bad with NeoGo, try synchronizing a C# node and you'll realize that you're lucky to be able to do that in a few hours.

@roman-khimov roman-khimov closed this as not planned Won't fix, can't repro, duplicate, stale Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants