Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include connect_timeout option for latency tests #37

Open
nroi opened this issue Dec 20, 2020 · 0 comments
Open

Include connect_timeout option for latency tests #37

nroi opened this issue Dec 20, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@nroi
Copy link
Owner

nroi commented Dec 20, 2020

DNS lookups can take a bit of time, but DNS requests are cached, so we don't want to exclude mirrors just because the DNS lookup took a bit longer than usual. However, we currently only use a single timeout in our latency tests, which is the total timeout of the entire request.

We should also add the connect_timeout so that we can exclude high-latency mirrors without excluding mirrors just because DNS took a bit longer.
@nroi nroi added the enhancement New feature or request label Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nroi