Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with ws > 1.0, security issues #29

Open
alexchandel opened this issue Aug 18, 2021 · 5 comments
Open

Compatibility with ws > 1.0, security issues #29

alexchandel opened this issue Aug 18, 2021 · 5 comments

Comments

@alexchandel
Copy link

The ws project is now at version 8.2.0. You depend on version 0.4.27. There are lots of intervening security fixes. Are you compatible with ws 8.2.0, or do you depend on the earlier compromised versions?

@CendioOssman
Copy link
Member

No idea. This version of websockify isn't really maintained. I suggest you test and see if a newer ws will work.

@alexchandel
Copy link
Author

Note that websockify.js crashes with new versions of ws, due to API changes, see #30

@saschazesiger
Copy link

If still needed, I made an updated Version that uses all the latest dependencies: https://github.com/saschazesiger/websockify-js-express

@CendioOssman
Copy link
Member

You are welcome to submit a PR if you have some fixes that you think are appropriate to merge here.

@saschazesiger
Copy link

Maybe its useful for some but its just my implementation of websockify and doesn't really fit in this repository.. Maybe i'll have time to make a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants