Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting or working on the FPLO parser. #156

Open
JosePizarro3 opened this issue Sep 8, 2023 · 8 comments
Open

Deleting or working on the FPLO parser. #156

JosePizarro3 opened this issue Sep 8, 2023 · 8 comments
Assignees
Labels
feature / enhancement New feature or request

Comments

@JosePizarro3
Copy link
Collaborator

@ladinesa @ndaelman-hu I just checked the FPLO parser.

Is anybody outside our team developing this parser? If not, I see two options:

  • We work properly on it and parse the metadata.
  • We delete it. This is my preferred option, but I would like to hear from you (maybe someone is developing it in an OASIS).
@JosePizarro3 JosePizarro3 added the question Further information is requested label Sep 8, 2023
@ladinesa
Copy link
Collaborator

ladinesa commented Sep 8, 2023

It is a basic parser, essentially waiting for development. I suggest you do not delete it but rather work on it if you like. You can try to adapt an existing parser if you prefer it but we should develop it independently. This is the essence of parser plug ins.

@JosePizarro3
Copy link
Collaborator Author

If it is waiting for development, shouldn't be moved to another project? I thought atomistic, electronic, etc., are parsers that are more or less under control.

For me, it is questionable to say that we support FPLO.

What do you think @ndaelman-hu ?

@ndaelman-hu
Copy link
Contributor

ndaelman-hu commented Sep 8, 2023

We have over 2.5k entries that are identified as FPLO Geometry Optimization, so we should serve them too.
Still, it isn't entirely clear how these are labelled as such, given how bare-bones the FPLO parser is. @ladinesa Do you know?

@ladinesa
Copy link
Collaborator

ladinesa commented Sep 8, 2023

I wrote BasicParser a few years back to parse basic calculation and system info for cover the parsers that have zero entries in nomad hence very little incentive to write a full parser. Now that you have pointed out these entries, I will put it in my TODO list to build a full parser.

@ndaelman-hu
Copy link
Contributor

Okay, thx! I am subscribed to the FPLO newsletter, if you need additional intel.

@ladinesa ladinesa self-assigned this Sep 8, 2023
@JosePizarro3
Copy link
Collaborator Author

Great, thanks @ladinesa 👍🏻

@JosePizarro3
Copy link
Collaborator Author

By the way, there was a recent issue in the FORUM related with FPLO: https://matsci.org/t/changing-reference-for-all-publications-in-a-dataset/50381/9

If you need help, I can lend you a hand for the Wannier parsing in FPLO, but for this I would need some example files. Let me know if you want me to take care of it in a future.

@JosePizarro3 JosePizarro3 added feature / enhancement New feature or request and removed question Further information is requested labels Sep 11, 2023
@JosePizarro3
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature / enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants