Prep 0.14.0 Release #743
Comments
|
In addition to those you mentioned it would be good to get #708 in if possible. It's been open a while and the original feature requester approved of the implementation. Other than that most other PRs seem to be incomplete or not fully reviewed/required |
|
Great, I think this is ready to go - anything missing @j5awry ? |
|
I think we're good for a release on this commit: I don't see docs on doing a release. I see bumpr.rc, which indicates that bumpr has been used. Sounds like it's still a task for @noirbizarre Axel, could you do a release off the commit above? |
|
We just need to push a new tag and the release is automated from that -
@noirbizarre changed it a while ago iirc 😁
…On Fri, 1 Nov 2019, 17:55 John Chittum, ***@***.***> wrote:
I think we're good for a release on this commit:
d4ace9c
<d4ace9c>
I don't see docs on doing a release. I see bumpr.rc, which indicates that
bumpr has been used. Sounds like it's still a task for @noirbizarre
<https://github.com/noirbizarre>
Axel, could you do a release off the commit above?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#743?email_source=notifications&email_token=ADRFTVCSJXYHIFUJMMQ3BG3QRRUQ5A5CNFSM4JFSHAT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC3V44I#issuecomment-548888177>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADRFTVE2AKDFTI4NU2EFV4DQRRUQ5ANCNFSM4JFSHATQ>
.
|
|
Please add all that info to the CONTRIBUTION.md or other relevant doc. Let's not leave that to institutional knowledge. I saw in a ticket asking for automating release, but never saw the final outcome. |
|
Yes I agree, that should have been when it was implemented. @noirbizarre
made the change so I'm not 100% sure on the details but I'll see what I can
find and get a PR up for it 👍
…On Fri, 1 Nov 2019, 18:10 John Chittum, ***@***.***> wrote:
Please add all that info to the CONTRIBUTION.md or other relevant doc.
Let's not leave that to institutional knowledge. I saw in a ticket asking
for automating release, but never saw the final outcome.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#743?email_source=notifications&email_token=ADRFTVANXOZHYLRBZEQCZG3QRRWIRA5CNFSM4JFSHAT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC3XG2Y#issuecomment-548893547>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADRFTVBI5HDY2GPJCTS6KO3QRRWIRANCNFSM4JFSHATQ>
.
|
|
Hmmm, so I've found the message on Gitter where we discussed this with @noirbizarre:
Shortly after this the 0.13.0 release was made by @noirbizarre , however I cannot see any changes to Looks like we're going to have to wait for @noirbizarre again on this. |
|
I think we could merge #637 as well. |
|
I'll be looking forward to this release including #673! 👍 |
|
To keep this issue up to date with current state of affairs, as discussed on Gitter I reached out to @noirbizarre via Twitter DMs on 10/11/2019 to try and get his assistance with making a release. On 21/11/2019 I received a reply stating that he will review the release issue (this one), make the release and then automate subsequent releases (as intended previously) so the maintainers can manage releases without his direct intervention. We have received no further communication and (clearly) the release has not been made 🤔 The other maintainers and myself apologise for the delay and lack of progress on the project, however it is currently out of our hands as we need @noirbizarre to make the release to PyPi. |
|
Any idea about the release date? |
|
@SteadBytes any way we can get someone else with @noirbizarre privileges for the project so we dont have the to worry about the bus factor https://en.wikipedia.org/wiki/Bus_factor |
|
@CrazyBonze That's what we're trying to do, however we need @noirbizarre to give those privileges in the first place 🤔 |
|
@rogeriolino Unfortunately no, sorry. The code is ready to go, however the other maintainers and I need @noirbizarre to make the actual release and (as previously stated) he has yet to make the release and/or communicate back with us why not. Apologies again, we'll keep this thread updated with progress if any is made 👍 |
|
@SteadBytes Why don't we make a fork for now with the aim of being an up to date drop in replacement for flask-restplus? This has the advantage of a) releasing updates to the community while b) possibly giving the owner some encouragement to maintain this project or hand it to somebody who will. |
|
+1 for fork. It's a bsd-3 license, so we can fork and even create a new thing in Pypi, as long as we keep all licensing in place, and state it's a derivative work. Otherwise, we can consider this dead, and start looking to move to other frameworks (I've mentioned where I'm pointing folks in other places) I'll note that if we're thinking of forking, it might be worth planning the project again on "what a 1.0" would look like. |
|
@cal97g Yep, I think that's a good suggestion 👍 @j5awry , as long as we're good on the licence side the only issue is what to call it - I don't think I can bring myself to make a Flask-RestPlusPlus 😝 Also, I agree, some planning and design for a 1.0 is definitely a good idea, if this is feasible we need some goals to work to other than "fix bugs and add new bits here and there" 😁 |
|
Presumably we can take inspiration from the issue still present here both for bug fixes and 1.0.0 features. @SteadBytes is better placed than me to recommend these. I've started a new project and invited steadybytes. I've cloned this repo, keeping history intact. I did go with Flask-RestPlusPlus but we can rename it later, or keep it 🤣 If we can get some new issues on this project I will be happy to contribute some time writing code + reviewing PR's. |
|
Thanks for the invite @cal97g 😊 However I'm going to hold off until some of the other maintainers have had their say, we've all invested a lot of time in this and I don't want to start a fork without their input. @j5awry has mentioned on Gitter that he needs a little bit of time to evaluate his available commitment for the future (real life is more important!) and we're yet to hear from the others. I will wait until this weekend and then move forwards - does that sound ok? |
|
@SteadBytes yep sounds good to me. I'm just keen to make things happen as I'm now using this in production. |
|
@cal97g Still waiting to hear back from @j5awry (no rush), @ziirish is also in favour of forking and I haven't heard from the others. I'm aware that you've forked the project yourself and invited me (thanks again btw), however I'm considering whether it might be best for the existing maintainers to start the new fork 🤔 I am by no means suggesting that you're not a valid and welcomed contributor, however it sounds like you're reasonably new to the project and i think it makes sense for the existing maintainers to start moving it forward with the new fork. Again, your (and others) contributions will be of course welcome! |
|
@SteadBytes I don't disagree, once we have some sort of consensus here I will be happy to delete / handover the fork and move with whatever the current maintainers propose. I probably jumped the gun a little bit 🥇 |
|
Hi, As said on gitter, we should have heard from @noirbizarre since we tried to get in touch for weeks/months. We'll need an org to make things more sustainable. If you have any idea for a name feel free to propose it. What do you think? |
|
Thanks @cal97g that's very understanding and reasonable of you! @ziirish yes I agree an org might be a good idea 👍 With regards to the name I don't have any great ideas right now, but I'm not sure about Flask-RestSwag either 🤣 There is also discussion between myself and the other maintainers over on Gitter as to how we'll proceed. General consensus at the moment is to hold off another week or so until the end of the year to allow the maintainers time to work out their level of commitment moving forward 😊 |
|
Hi Guys, |
|
Hey @SVilgelm , some discussion is happening over on Gitter whilst waiting for other maintainers to confirm their availability/willingness to go ahead now that the new year is here. I agree 100% that an organisation is the way to go 👍 I'm thinking a As for the name, I'm undecided (suggestions are welcome of course) however, personally I wouldn't tie the name directly to OpenAPI 😊 |
|
@SteadBytes thanks, i did read the conversation on gitter and as i said. Would be glad to do this for you, if you have no time for such work - forking, creating pypi, configuring all needed actions to check pr and release the versions and etc... |
|
As stated earlier. Since the grace period is over, let's go ahead and fork this project. To be 100% transparent, I'm a newbie with all the OpenAPI/Swagger things so I'm offering to focus my contributions on the core, the tests and all the release tooling if that can be of any help. |
We've accumulated a fair set of fixes. There are 2 more PRs in the pipeline that I think should get grabbed in
#739
#741
After those, and any other intermediary PRs, we should cut a release. Some prep things we should do:
The text was updated successfully, but these errors were encountered: